Matplotlib to chaco cheatsheet in docs #723
Merged
Merged
Conversation
rahulporuri
reviewed
May 4, 2021
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
rahulporuri
approved these changes
May 5, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM with one minor nitpicky comment
| options for the ``axis`` argument. In chaco ``'x'`` and ``'y'`` are the names | ||
| the ``PlotData`` object associates with numpy arrays ``x`` and ``y``. | ||
|
|
||
| .. list-table:: Matplotlib To Chaco Cheatsheet |
Contributor
There was a problem hiding this comment.
there's something new i learnt today!
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
Contributor
|
@achabotl can you make time to review this PR? |
achabotl
reviewed
May 5, 2021
Contributor
achabotl
left a comment
achabotl
left a comment
There was a problem hiding this comment.
Thank you for making this! LGTM.
See inline comments, mainly for consistency of naming and some formatting.
Co-authored-by: Alexandre Chabot-Leclerc <achabotl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #690
This PR adds a brief section to the documentation giving a "cheatsheet" of code "equivalences" between matplotlib and chaco.
It effectively copies the table given in the issue, and adds a short introduction to it / fills in a couple empty sections