re-export PolarLineRenderer and PolarMapper from chaco.api#732
Merged
Conversation
… an older version of LinearMapper)
rahulporuri
reviewed
May 10, 2021
Comment on lines
+50
to
+53
| if isinstance(data_array, (tuple, list, ndarray)): | ||
| return full_like(data_array, self.low_pos, dtype=float64) | ||
| else: | ||
| return array([self.low_pos]) |
Contributor
There was a problem hiding this comment.
I'm not sure why these changes were made. Were these changes copied over from the linear mapper?
Contributor
There was a problem hiding this comment.
I have the same comment about the changes in map_data and _compute_scale
Contributor
Author
There was a problem hiding this comment.
Were these changes copied over from the linear mapper?
Yeah, I effectively copied the current LinearMapper here
rahulporuri
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #629
This PR simply re-exports the 2 classes from the api module.
It also pulls a comment about
PolarMappercurrently just being LinearMapper into the docstring so it appears on api docs. Eventually we will want to update it, see #47. In the meanwhile it is fine to like in the api as long as this is documented.(Actually looking at it, it looks like some changes have been made to LinearMapper that weren't copied over... I may go ahead and pull those directly so that the PolarMapper really does just match the LinearMapper like it says).
EDIT: done. The PolarMapper is now the current LinearMapper rather than an old version of the LinearMapper.