Skip to content

replace [] default for data with None #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronayres35 merged 1 commit into from
May 10, 2021
Merged

replace [] default for data with None #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions chaco/plot_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _create_data_sources(data, index_sort="none"):


def create_scatter_plot(
data=[],
data=None,
index_bounds=None,
value_bounds=None,
orientation="h",
Expand All @@ -69,6 +69,8 @@ def create_scatter_plot(

Pre-existing "index" and "value" datasources can be passed in.
"""
if data is None:
data = []

index, value = _create_data_sources(data)

Expand Down Expand Up @@ -109,7 +111,7 @@ def create_scatter_plot(


def create_line_plot(
data=[],
data=None,
index_bounds=None,
value_bounds=None,
orientation="h",
Expand All @@ -130,6 +132,9 @@ def create_line_plot(

Pre-existing "index" and "value" datasources can be passed in.
"""
if data is None:
data = []

index, value = _create_data_sources(data, index_sort)

if index_bounds is not None:
Expand Down Expand Up @@ -168,7 +173,7 @@ def create_line_plot(


def create_bar_plot(
data=[],
data=None,
index_bounds=None,
value_bounds=None,
orientation="h",
Expand All @@ -191,6 +196,9 @@ def create_bar_plot(

Pre-existing "index" and "value" datasources can be passed in.
"""
if data is None:
data = []

index, value = _create_data_sources(data)

if index_bounds is not None:
Expand Down