Skip to content

Add pyproject.toml to MANIFEST.in#747

Merged
aaronayres35 merged 1 commit into
masterfrom
add-pyproject-toml-to-manifest
Jun 2, 2021
Merged

Add pyproject.toml to MANIFEST.in#747
aaronayres35 merged 1 commit into
masterfrom
add-pyproject-toml-to-manifest

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 commented Jun 2, 2021

following the lead of enthought/enable#836
This was missed in PR #730

@aaronayres35 aaronayres35 requested a review from rahulporuri June 2, 2021 15:03
rahulporuri
rahulporuri approved these changes Jun 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35
Copy link
Copy Markdown
Contributor Author

aaronayres35 commented Jun 2, 2021

appveyor CI failed with:

Running Install scripts
install-edm-windows.cmd
Exception calling "DownloadFile" with "2" argument(s): "The remote name could 
not be resolved: 'package-data.enthought.com'"
At line:1 char:1
+ (new-object net.webclient).DownloadFile('https://package-data.enthoug ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : WebException
 
ERROR
Command exited with code 1

restarting now

@aaronayres35
Copy link
Copy Markdown
Contributor Author

aaronayres35 commented Jun 2, 2021

appveryor failing again, now with:

Creating environment 'chaco-test-3.6-pyside2'
[EXECUTING] edm environments create chaco-test-3.6-pyside2 --force --version=3.6
Fetching indices for runtime repositories done
HTTPSConnectionPool(host='packages.enthought.com', port=443): Max retries exceeded with url: /api/v1/json/indices/enthought/free/win_x86_64/runtimes (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x0000000004ADAEF0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))
Traceback (most recent call last):
  File "C:\Jenkins\workspace\edm\installer\edm\cli\context.py", line 232, in invoke
  File "C:\Jenkins\workspace\edm\installer\edm\cli\click_custom.py", line 192, in invoke
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\click\core.py", line 1137, in invoke
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\click\core.py", line 1137, in invoke
  File "C:\Jenkins\workspace\edm\installer\edm\cli\click_custom.py", line 72, in invoke
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\click\core.py", line 956, in invoke
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\click\core.py", line 555, in invoke
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\click\decorators.py", line 27, in new_func
  File "C:\Jenkins\workspace\edm\installer\edm\cli\environments.py", line 120, in create_environment
  File "C:\Jenkins\workspace\edm\installer\edm\commands\environments.py", line 106, in create_environment_cmd
  File "C:\Jenkins\workspace\edm\installer\edm\core\repository_utils.py", line 261, in _install_runtime
  File "C:\Jenkins\workspace\edm\installer\edm\core\repository_utils.py", line 241, in _fetch_runtime
  File "C:\Jenkins\workspace\edm\installer\edm\core\repository_utils.py", line 89, in runtimes_repositories_factory
  File "C:\Jenkins\workspace\edm\installer\edm\core\repository_utils.py", line 58, in _repository_factory
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\concurrent\futures\_base.py", line 455, in result
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\concurrent\futures\thread.py", line 63, in run
  File "C:\Jenkins\workspace\edm\installer\edm\network\asset_fetcher.py", line 429, in runtimes_repository
  File "C:\Jenkins\workspace\edm\installer\edm\network\asset_fetcher.py", line 293, in _fetch_runtimes_index
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\hatcher\core\v1\repository.py", line 58, in runtime_index
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\hatcher\core\brood_url_handler.py", line 355, in get_json
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\hatcher\core\brood_url_handler.py", line 131, in _request
  File "C:\Jenkins\workspace\edm\installer\edm\network\session.py", line 210, in get
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\requests\sessions.py", line 543, in get
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\requests\sessions.py", line 530, in request
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\requests\sessions.py", line 643, in send
  File "C:\Users\vagrant\.edm\envs\edm-build\lib\site-packages\requests\adapters.py", line 516, in send
ConnectionError: HTTPSConnectionPool(host='packages.enthought.com', port=443): Max retries exceeded with url: /api/v1/json/indices/enthought/free/win_x86_64/runtimes (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x0000000004ADAEF0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))
Unexpected error: ConnectionError(MaxRetryError("HTTPSConnectionPool(host='packages.enthought.com', port=443): Max retries exceeded with url: /api/v1/json/indices/enthought/free/win_x86_64/runtimes (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x0000000004ADAEF0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))",),)
The traceback has been recorded into the file 'c:\users\appveyor\appdata\local\temp\1\tmpoxkmgy'. Please send or copy/paste the content of that file when reporting this issue
Command exited with code 1

@aaronayres35 aaronayres35 merged commit ae7eaef into master Jun 2, 2021
@aaronayres35 aaronayres35 deleted the add-pyproject-toml-to-manifest branch June 2, 2021 15:47
aaronayres35 added a commit that referenced this pull request Jun 2, 2021
@aaronayres35
add pyproject.toml to MANIFEST.in (#747)
c0f0b5a
aaronayres35 added a commit that referenced this pull request Jun 2, 2021
@aaronayres35 @xiaoyu-wu
Backport PRs to maint/5.0 (#749)
f923c6d 
* FIX: fix scrollbar demo and update docstring (#489)

Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>

* Add new chaco.plots submodule (#738)

* add new chaco.plots submodule

* move contour_line_plot.py and contour_poly_plot.py into chaco/plots/contour

* import from api in tests

* move relevant tests into chaco/plots/tests

* add stub files at old file locations which raise Deprecation warning and import objects from their new chaco/plots modules

* flake8

* update warning message

* set stacklevel=2 in deprecation warnings

* add a chaco.plots.api

* typo

* update deprecation warning messages, and remove module docstrings

* Apply suggestions from code review

Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>

* ignore stub modules when generating api docs

* flake8

* update api module docstrings

* reorder imports

* suggestions from code review

Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>

* add pyproject.toml to MANIFEST.in (#747)

* Consolidate overlays into "chaco.overlays" (#741)

* copy modules into chaco/overlays

* make original modules stubs raising deprecation warnings

* copy layers into overlays

* fully populate chaco.overlays.api and chaco.api

* flake8

* update tox.ini by running flake8 -q

* somehow this is also needed in tox.ini but I did not see this flake8 error locally

* remove bad trailing comma

* move data label test to sit in chaco/overlays/tests

* add stub modules in chaco/layers importing from new location and adding deprecation warnigns.  Also expose layers in the chaco.overlays.api

* add layers to the chaco.api as well

* old files that were moved have since been changed on master and did not get updated in merge of master

* flake8

* typo

* update deprecation warning messages

* remove stub modules from autogenerated api docs

* remove chaco/layers/data

* import from chaco.plots in overlay modules

* import Legend from chaco.overlays.api

Co-authored-by: Xiaoyu Wu <xiaoyu-wu@users.noreply.github.com>
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rahulporuri rahulporuri rahulporuri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronayres35 @rahulporuri