Update requirements to be more specific#752
Conversation
|
|
||
| __requires__ = ["traits", "traitsui", "pyface", "numpy", "enable"] | ||
| __requires__ = [ | ||
| "traits>=6.2.0", "traitsui", "pyface>=7.2.0", "numpy", "enable>=5.2.0" |
There was a problem hiding this comment.
I should check that a release candidate actually counts for >= . Otherwise even with the enable 5.2.0rc2 out, there will not be available packages on PyPI satisfying the requirements when we make the rc for chaco.
If that is the case, I will unpin this requirement until after the chaco rc is made, and after enable 5.2.0 is fully released, but before chaco 5.0.0 is release
I'm not a 100% sure why enable 5.2 is required. This will only be true after #674 IIUC. Right? |
rahulporuri
left a comment
There was a problem hiding this comment.
Almost LGTM.
I haven't tested this locally but what happens if you just pip install chaco from source in the maintenance branch now? A 5.2.0 doesn't exist in pypi yet and i'm wondering if the installation fails.
This doesn't work as I expected. I see the following error when I try to install a chaco sdist in a clean environment - |
Yeah I just caught that myself, this is what I was unsure about in the PR description. I will unpin this now, but we may want to repin it later (post chaco rc and enable full release) |
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. We'll need to remember to change this once enable 5.2.0 is released 😅
Looking closer I believe that is correct, I don't know why I had it in my head there was something else. I was jumping the gun too early with this PR |
[targeting maint/5.0]
This PR updates
__requires__to be more specific.We use
Property(observe=...)and so depend on traits >= 6.2. Also recent changes are such that we require enable 5.2 (only rc currently available). Also enable 5.2 (and actually I think 5.1) require pyface >=7.2 as it usespyface.undo. So, chaco implicitly requires pyface >= 7.2TBH I am not exactly sure on what traitsui is necessary (we didnt specify for enable either)
This PR will eventually need to be backported into master along with the recent changelog updates