Fix _draw_overlay in chaco.axis#772
Merged
Merged
Conversation
…ault value of None for component. Similarly _compute_tick_positions has a default value of None for other_component. In this case we can just not pass anything as it should be None
Contributor
|
Just confirming that this will be backported to |
Contributor
Author
This PR is actually targeting |
aaronayres35
added a commit
that referenced
this pull request
Jun 10, 2021
…ault value of None for component. Similarly _compute_tick_positions has a default value of None for other_component. In this case we can just not pass anything as it should be None (#772)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken in #743
componentwas always None in this case (hence the removedif component is not None:. I had just missed this before.