Skip to content

Explicitly require enable 5.2.0 which is now on PyPI#789

Merged
aaronayres35 merged 1 commit into
maint/5.0from
require-enable-5.2
Jun 15, 2021
Merged

Explicitly require enable 5.2.0 which is now on PyPI#789
aaronayres35 merged 1 commit into
maint/5.0from
require-enable-5.2

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 commented Jun 15, 2021

Now that enable 5.2.0 has been uploaded to pypi, we can explicitly add the requirement.

This PR should be pulled back into master as well

@aaronayres35 aaronayres35 requested a review from rahulporuri June 15, 2021 14:45
@aaronayres35 aaronayres35 mentioned this pull request Jun 15, 2021
Closed
44 tasks
rahulporuri
rahulporuri approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that we'll also need the changes to ci\edmtool.py along with this to ensure that CI also tests against enable from PyPI.

@aaronayres35
Copy link
Copy Markdown
Contributor Author

aaronayres35 commented Jun 15, 2021 •
edited
Loading

LGTM. Note that we'll also need the changes to ci\edmtool.py along with this to ensure that CI also tests against enable from PyPI.

Should those changes be included in the release or just on master?
I believe CI is currently using enable from the maint/5.2 branch. I can update to pull enable from pypi instead
Since this is a CI specific fix I am going to go ahead with the release and make that update to master soon after. Is that okay with you @rahulporuri or would you prefer this to be included in the release?

@aaronayres35 aaronayres35 merged commit 228b039 into maint/5.0 Jun 15, 2021
@aaronayres35 aaronayres35 deleted the require-enable-5.2 branch June 15, 2021 15:45
@rahulporuri
Copy link
Copy Markdown
Contributor

rahulporuri commented Jun 15, 2021

Since this is a CI specific fix I am going to go ahead with the release and make that update to master soon after. Is that okay with you @rahulporuri or would you prefer this to be included in the release?

This doesn't have to be included in the release and the changes themselves will be simplified once the edm eggs for enable 5.2.0 become available - but the changes need to be made both on the master and the maint/5.0 branches.

aaronayres35 added a commit that referenced this pull request Jun 17, 2021
@aaronayres35
explicitly require enable 5.2.0 which is now on pypi (#789)
4f84a30
aaronayres35 added a commit that referenced this pull request Jun 18, 2021
@aaronayres35
Backport changelog and fixes (#797)
fa0989f 
* copy over changelog from maint/5.0

* explicitly require enable 5.2.0 which is now on pypi (#789)

* fix a couple more links in documentation (#793)

* fix more broken links (#794)

* add contributors list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rahulporuri rahulporuri rahulporuri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronayres35 @rahulporuri