Skip to content

Make map_screen return an empty array not empty list in empty input case#805

Merged
aaronayres35 merged 1 commit into
masterfrom
return-empty-arrays
Jul 7, 2021
Merged

Make map_screen return an empty array not empty list in empty input case#805
aaronayres35 merged 1 commit into
masterfrom
return-empty-arrays

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

This pulls some additional changes out of #726.

This is to keep the return type for the method consistent

@aaronayres35 aaronayres35 requested a review from rahulporuri July 7, 2021 14:16
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit d83e4b8 into master Jul 7, 2021
@aaronayres35 aaronayres35 deleted the return-empty-arrays branch July 7, 2021 14:41
@corranwebster corranwebster added the needs backport Needs to be backported to current maint/* label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport Needs to be backported to current maint/*

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants