fix hittest_tool.py example use of map_screen#808
Merged
Conversation
aaronayres35
changed the title
rahulporuri
approved these changes
Jul 8, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM.
Let's audit the other potentially broken examples later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example became broken by the recent changes to map_screen.
This change was pulled from #726
Note there are some other examples which did not get pulled into
chaco/examplesthat could be fixed as well. I did not do that as I could not recall if they were planned to be deleted entirely. See #726 changes toexamples/tutorials/...I am happy to make those changes on this PR if need be.