Setup slack notification for cron jobs#811
Merged
Merged
Conversation
modified: .github/workflows/ets-from-source.yml
rahulporuri
changed the title
modified: .github/workflows/ets-from-source.yml
aaronayres35
approved these changes
Jul 13, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
although I believe the manually triggered run / slack notification were for the first commit. Nonetheless the changes LGTM (as they match those made in all other ets repos)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up the slack notifications for the cron jobs. I manually triggered the cron jobs on this branch to ensure that the slack notifications are fired as expected. Ref https://github.com/enthought/chaco/actions/runs/1027318233
One more step towards enthought/ets#65