Add action to publish to PyPI#839
Merged
Merged
Conversation
mdickinson
approved these changes
Oct 28, 2022
| steps: | ||
|
|
||
| - name: Check out the release commit | ||
| uses: actions/checkout@v2 |
Member
There was a problem hiding this comment.
Suggest using the latest version here:
Suggested change
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v3 |
| - name: Set up Python | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '3.8' |
Member
There was a problem hiding this comment.
Consider using Python 3.10, for longevity?
| if: runner.os == 'Linux' | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v2 |
Member
There was a problem hiding this comment.
Suggest using latest version
Suggested change
| uses: actions/setup-python@v2 | |
| uses: actions/setup-python@v4 |
|
|
||
| - name: Install Python packages needed for wheel build and upload | ||
| run: | | ||
| python -m pip install --upgrade pip setuptools |
Member
There was a problem hiding this comment.
Nitpick: This step shouldn't be needed: if we have a pyproject.toml, we don't need setuptools, and pip is automatically updated to the latest version by the setup-python action.
| - name: Install Python packages needed for wheel build and upload | ||
| run: | | ||
| python -m pip install --upgrade pip setuptools | ||
| python -m pip install twine wheel |
Member
There was a problem hiding this comment.
I don't think we need wheel here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will need appropriate secrets added.