Add Python 3.8 tests#851
Merged
Merged
Conversation
aaronayres35
approved these changes
Jan 23, 2023
corranwebster
added a commit
that referenced
this pull request
Jan 24, 2023
This adds a parallel set of tests for Python 3.8 rather than trying to adapt the current set of tests. Also updates edmtool to allow Python 3.8 and PySide6, and pyproject.toml to allow for known issue with setuptools. Needed to make one change to code due to newer version of NumPy being picked up. No requirement that they pass for PRs to be mergeable yet, but will likely add that once this PR is approved.
corranwebster
added a commit
that referenced
this pull request
Jan 24, 2023
This adds a parallel set of tests for Python 3.8 rather than trying to adapt the current set of tests. Also updates edmtool to allow Python 3.8 and PySide6, and pyproject.toml to allow for known issue with setuptools. Needed to make one change to code due to newer version of NumPy being picked up. No requirement that they pass for PRs to be mergeable yet, but will likely add that once this PR is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a parallel set of tests for Python 3.8 rather than trying to adapt the current set of tests. Also updates edmtool to allow Python 3.8 and PySide6, and pyproject.toml to allow for known issue with setuptools.
Needed to make one change to code due to newer version of NumPy being picked up.
No requirement that they pass for PRs to be mergeable yet, but will likely add that once this PR is approved.