Skip to content

Fire Range updated event when data sources are set to empty#900

Merged
corranwebster merged 1 commit into
mainfrom
fix/empty-data-range-reset
May 16, 2023
Merged

Fire Range updated event when data sources are set to empty#900
corranwebster merged 1 commit into
mainfrom
fix/empty-data-range-reset

Conversation

@corranwebster
Copy link
Copy Markdown
Contributor

@corranwebster corranwebster commented May 12, 2023

The updated event on a DataRange1D was not being fired when the last data source was removed. This fixes that.

Fixes #821

@corranwebster corranwebster changed the title Fire updated event when data sources are set to empty Fire Range updated event when data sources are set to empty May 12, 2023
Copy link
Copy Markdown
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@corranwebster corranwebster merged commit 30be22c into main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing a data source makes DataView objects inconsistent

2 participants