Strange import failure on RHEL 7

[capn-freako]

Since updating my enable installation to 5.2.1, via building from source, I'm getting the following strange import error, only on RHEL 7. I don't get this error when running under MacOS.

    import enable.savage.svg.css
  File "foo/lib/python3.8/site-packages/enable/savage/svg/css/__init__.py", line 10, in <module>
    from .transform import transformList
  File "foo/lib/python3.8/site-packages/enable/savage/svg/css/transform.py", line 18, in <module>
    from enable.savage.svg.pathdata import number, maybeComma
  File "foo/lib/python3.8/site-packages/enable/savage/svg/pathdata.py", line 117, in <module>
    lineTo = Group(Command("L") + Arguments(coordinatePairSequence))
  File "foo/lib/python3.8/site-packages/enable/savage/svg/pathdata.py", line 29, in Command
    return CaselessPreservingLiteral(char)
  File "foo/lib/python3.8/site-packages/enable/savage/svg/pathdata.py", line 43, in __init__
    self.name = "'%s'" % matchString
AttributeError: can't set attribute

[rahulporuri]

thanks for the report @capn-freako .

ref

enable/enable/savage/svg/pathdata.py

Lines 36 to 43 in 78d2e49

	class CaselessPreservingLiteral(CaselessLiteral):
	""" Like CaselessLiteral, but returns the match as found
	instead of as defined.
	"""
	def __init__(self, matchString):
	super().__init__(matchString.upper())
	self.name = "'%s'" % matchString

CaselessPreservingLiteral inherits from pyparsing.CaselessLiteral and the name attribute seems to belong to the pyparsing class. Can you report what versions of pyparsing you are using on RHEL7 and MacOS?

[capn-freako]

pyparsing versions: RHEL: 3.0.4 MacOS: 2.4.7

…

On Nov 8, 2021, at 6:02 AM, Poruri Sai Rahul ***@***.***> wrote: thanks for the report @capn-freako <https://github.com/capn-freako> . ref https://github.com/enthought/enable/blob/78d2e494097fac71cc5c73efef5fb464963fb4db/enable/savage/svg/pathdata.py#L36-L43 <https://github.com/enthought/enable/blob/78d2e494097fac71cc5c73efef5fb464963fb4db/enable/savage/svg/pathdata.py#L36-L43> CaselessPreservingLiteral inherits from pyparsing.CaselessLiteral and the name attribute seems to belong to the pyparsing class. Can you report what versions of pyparsing you are using on RHEL7 and MacOS? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#887 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH7XGVCVPFH44GJXLBH6JTUK5KXRANCNFSM5HOOZBUQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[rahulporuri]

RHEL: 3.0.4

Can I ask whether this behaviour persists if you downgrade pyparsing to a version < 3 on RHEL?

[rahulporuri]

RHEL: 3.0.4

I don't see anything in version 3 of pyparsing which might be causing this issue - https://pyparsing-docs.readthedocs.io/en/latest/whats_new_in_3_0_0.html.

[capn-freako]

Okay, thanks! I’ve asked the engineer I’m working with to fall back to v2.4.7 of pyparsing and report back. In the meantime, is it possible that `name` became a read-only property of pyparsing with the release of version 3? Thanks, -db

…

On Nov 8, 2021, at 10:32 AM, Poruri Sai Rahul ***@***.***> wrote: RHEL: 3.0.4 I don't see anything in version 3 of pyparsing which might be causing this issue - https://pyparsing-docs.readthedocs.io/en/latest/whats_new_in_3_0_0.html <https://pyparsing-docs.readthedocs.io/en/latest/whats_new_in_3_0_0.html>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#887 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH7XGT2B56RFM6MBPY6WPTUK6KMPANCNFSM5HOOZBUQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[rahulporuri]

In the meantime, is it possible that name became a read-only property of pyparsing with the release of version 3?

Spot on.

https://github.com/pyparsing/pyparsing/blob/0352555d968f9952800f0728383de8e1f9526e1e/pyparsing/core.py#L1802-L1805

CaselessLiteral inherits from Token which inherits from ParserElement. name is a property on ParserElement. Looks like the right way to set/update name on a CaselessLiteral is now using the ParserElement.set_name method.

[rahulporuri]

@capn-freako #888 should fix the issue. Will you be able to test the fix?

[capn-freako]

Hi @rahulporuri ,

Sorry for the delay.
Yes, your commit has fixed the problem.

Thanks!
-db