Remove support for Numeric (as opposed to NumPy) from Kiva#1011
Merged
Conversation
jwiggins
reviewed
Apr 19, 2023
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out there was some code that was available to support, and some that used, the Numeric C API (ie. the predecessor to NumPy). The compatibility headers that NumPy provided to help with this are going away, so this PR removes all uses of Numeric code.
Fixes #1005
Changes needed:
ifdef-ed out)PyArray_SBYTESwithPyArray_BYTESkiva.quartzto use current ways to get at NumPy and Python headersThis will also need #1007 merged in at some point.