Add explicit float -> int conversion for Qt#1041
Merged
Merged
Conversation
This was happening implicitly until https://bugs.python.org/issue36048 This makes it explicit, which means things should work with PyQt5 on Python 3.10.
jwiggins
approved these changes
Apr 18, 2023
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
Are these really the only call sites?
Contributor
Author
Quite likely the only ones that have a mismatch between floats and ints. The interface between the toolkit and Enable is fairly thin (here's a control, draw your stuff in it, listen for events; plus the native scrollbar stuff). On an unrelated note, this seems to have turned the MacOS wx tests back on somehow... I will fix before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was happening implicitly until https://bugs.python.org/issue36048 This makes it explicit, which means things should work with PyQt5 on Python 3.10.
Fixes #1037