Skip to content

Insist on Cython prior to 3.0#1063

Closed
drbsg wants to merge 1 commit into
enthought:maint/5.3from
drbsg:fix/use-older-cython
Closed

Insist on Cython prior to 3.0#1063
drbsg wants to merge 1 commit into
enthought:maint/5.3from
drbsg:fix/use-older-cython

Conversation

@drbsg
Copy link
Copy Markdown

@drbsg drbsg commented Aug 8, 2023

This is a back-port of pull request #1061 to the 5.3 maintenance branch.

Also put upper bound on Pillow for Qt5.
Copy link
Copy Markdown
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster Any objections? (you're a bit closer to this than me)

@corranwebster
Copy link
Copy Markdown
Contributor

PR looks good, not sure what's happening with CI

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Aug 8, 2023

Looks like the Wx environment needs attrdict installed before installing Wx

@drbsg
Copy link
Copy Markdown
Author

drbsg commented Aug 8, 2023

Looks like the Wx environment needs attrdict installed before installing Wx

I am not familiar with EDM, so would adding this dependency to dependencies for both versions in ci/edmtool.py be a good way to achieve this?

@corranwebster
Copy link
Copy Markdown
Contributor

I think the right way to fix would either be to restrict the WxPython version or to add attrdict here:

"wx": ["pyface[wx]", "traitsui[wx]"],

The problem seems to be this version of WxPython not declaring all dependencies.

@itziakos
Copy link
Copy Markdown
Member

#1070 updated code to work with Cython > 3.

@itziakos itziakos closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants