Insist on Cython prior to 3.0#1063
Closed
drbsg wants to merge 1 commit into
Closed
Conversation
Also put upper bound on Pillow for Qt5.
jwiggins
approved these changes
Aug 8, 2023
Member
jwiggins
left a comment
There was a problem hiding this comment.
LGTM
@corranwebster Any objections? (you're a bit closer to this than me)
Contributor
|
PR looks good, not sure what's happening with CI |
Member
|
Looks like the Wx environment needs |
Author
I am not familiar with EDM, so would adding this dependency to |
Contributor
|
I think the right way to fix would either be to restrict the WxPython version or to add Line 52 in 84b611d The problem seems to be this version of WxPython not declaring all dependencies. |
Member
|
#1070 updated code to work with Cython > 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a back-port of pull request #1061 to the 5.3 maintenance branch.