Skip to content

Added python 3.5 and 3.6 as targets#285

Merged
jwiggins merged 6 commits into
enthought:masterfrom
jdeschenes:travis_fixes
Aug 2, 2017
Merged

Added python 3.5 and 3.6 as targets#285
jwiggins merged 6 commits into
enthought:masterfrom
jdeschenes:travis_fixes

Conversation

@jdeschenes
Copy link
Copy Markdown
Contributor

@jdeschenes jdeschenes commented Jul 25, 2017 •
edited
Loading

Seems like it will fix #274 as well.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 25, 2017 •
edited
Loading

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   33.22%   33.22%           
=======================================
  Files         206      206           
  Lines       18559    18559           
  Branches     2520     2520           
=======================================
  Hits         6167     6167           
  Misses      11998    11998           
  Partials      394      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa33701...869a75b. Read the comment docs.

@jdeschenes
Exclude support for wx from python 3.5 and 3.6.
f00237b 
Added build steps for python 3.5 and python 3.6 with qt.
@jdeschenes
Copy link
Copy Markdown
Contributor Author

jdeschenes commented Jul 25, 2017

How do you propose to fix the build error for python 3 and qt?

@jdeschenes
Pyside Setup is apparently fixed.
5d89e6e
@jdeschenes
Excluding python 3.5 and 3.6 since they are not "supported"
cb121dc 
The pyside-setup only includes builds for 3.4, even though it looks
like the build for python 3.5 and 3.6 should be supported.
@jdeschenes jdeschenes mentioned this pull request Jul 25, 2017
Merged
@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Jul 26, 2017

See #281. I'll merge that soon and then this branch will need to be rebased/adapted

@jdeschenes
Copy link
Copy Markdown
Contributor Author

jdeschenes commented Jul 26, 2017

No problem. The changes in this branch are very minor.

@jdeschenes
Copy link
Copy Markdown
Contributor Author

jdeschenes commented Jul 26, 2017

Is there any reason why pyqt is not tested during the travis CI run?

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Jul 26, 2017

I think that's a relic of the days when it was thought that PySide would be the Qt binding going forward.... but don't quote me on that.

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Jul 27, 2017

This should only need an update to .travis.yml now that #281 is merged

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Aug 2, 2017

LGTM!

@jwiggins jwiggins merged commit 38e401c into enthought:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Continuous integration broken on Python 3.x / Qt+PySide

3 participants

@jdeschenes @codecov-io @jwiggins