Skip to content

BUG: Remove use of C API not available in Python 3.#299

Merged
rkern merged 3 commits into
masterfrom
fix/quartz-python3
Dec 1, 2017
Merged

BUG: Remove use of C API not available in Python 3.#299
rkern merged 3 commits into
masterfrom
fix/quartz-python3

Conversation

@rkern
Copy link
Copy Markdown
Member

@rkern rkern commented Nov 29, 2017

Importing kiva.quartz.ABCGI will fail otherwise.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 29, 2017

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #299   +/-   ##
======================================
  Coverage    33.6%   33.6%           
======================================
  Files         206     206           
  Lines       18278   18278           
  Branches     2407    2407           
======================================
  Hits         6142    6142           
  Misses      11744   11744           
  Partials      392     392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a325b5b...df99541. Read the comment docs.

@jvkersch
Copy link
Copy Markdown
Contributor

LGTM. Could you add a test to import the module?

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Dec 1, 2017

LGTMT

@rkern rkern merged commit 8b6861d into master Dec 1, 2017
@rkern rkern deleted the fix/quartz-python3 branch December 1, 2017 23:01
jwiggins pushed a commit that referenced this pull request Jul 12, 2018
BUG: Remove use of C API not available in Python 3.
@jwiggins jwiggins mentioned this pull request Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants