Skip to content

FIX: Ensure contiguous transposed arrays#309

Merged
jwiggins merged 1 commit into
masterfrom
fix/points-in-poly-want-a-cracker
Jul 3, 2018
Merged

FIX: Ensure contiguous transposed arrays#309
jwiggins merged 1 commit into
masterfrom
fix/points-in-poly-want-a-cracker

Conversation

@jwiggins
Copy link
Copy Markdown
Member

@jwiggins jwiggins commented Jul 3, 2018

This is a follow up to enthought/chaco#409. Cython expects arrays which will be assigned to a memoryview to be C-contiguous. Transposed arrays are not contiguous, so now we force them to be.

@jwiggins jwiggins requested a review from corranwebster July 3, 2018 09:15
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 3, 2018

Codecov Report

Merging #309 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   33.66%   33.66%           
=======================================
  Files         206      206           
  Lines       18299    18299           
  Branches     2411     2411           
=======================================
  Hits         6161     6161           
  Misses      11747    11747           
  Partials      391      391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1778b10...0353cbc. Read the comment docs.

Copy link
Copy Markdown
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwiggins jwiggins merged commit f470504 into master Jul 3, 2018
@jwiggins jwiggins deleted the fix/points-in-poly-want-a-cracker branch July 3, 2018 09:54
@jwiggins jwiggins mentioned this pull request Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants