Use config for bootstrapping a EDM environment#489
Merged
Conversation
jwiggins
reviewed
Dec 14, 2020
Member
|
Didn't realize EDM did this... I'm ready to approve as soon as CI is green |
jwiggins
approved these changes
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CI builds are failing because the default config created by EDM includes a repository to
enthought/commercialthat has beendeprecated(edited: removed). The default config should be fixed in EDM. In the meantime, this PR attempts to workaround the issue by specifying a config file to use.(Orthogonal: Presumably enable should always provide a config file in all the steps involving EDM... but at the same time, if we had always provided a config, it would be harder for such issue to reveal themselves.)