Fix AttributeError on Python 3.9 due to usage of removed API in xml#492
Merged
Conversation
jwiggins
approved these changes
Dec 15, 2020
Member
jwiggins
left a comment
There was a problem hiding this comment.
Less broken than before... Let's iterate as needed here.
Contributor
Author
|
Thanks. I will open an issue for the clip-path code path being unreachable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490
The first commit fixes errors that can be seen by running the test suite on Python 3.9.
The second commit makes similar changes, but those changes are not covered by tests.
On the changes that are not covered by test:
For
enable.svg.document.addRectToDocument. I was trying to write a test that does something like this:However it still does not reach the code path where I fixed the usage of ElementTree.
It seems that
if 'clip-path' in node:is always false. Previously it was doingif 'clip-path' in node.keys()wherekeys()returns the XML attributes, butnodewas thought to be adictduring a migration from Python 2 to 3 (see #284). Upon fixingin nodetoin node.keys(), I run into another difficulty trying to open an SVG referenced by the clip-path assuming it was a local file. So I eventually gave up. I am happy to revert the second commit owing to the fact it is untested.