Skip to content

Remove module level findfont in font_manager #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kitchoi merged 1 commit into from
Dec 16, 2020
Merged

Remove module level findfont in font_manager #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions kiva/fonttools/font_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,11 +1450,6 @@ def _load_from_cache_or_rebuild(cache_file):
return fontManager


def findfont(prop, **kw):
font = default_font_manager().findfont(prop, **kw)
return font


def default_font_manager():
""" Return the default font manager, which is a singleton FontManager
cached in the module.
Expand Down
15 changes: 0 additions & 15 deletions kiva/fonttools/tests/test_font_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from ..font_manager import (
createFontList,
default_font_manager,
findfont,
FontEntry,
FontProperties,
FontManager,
Expand Down Expand Up @@ -173,20 +172,6 @@ def test_default_font_manager(self):
font_manager = default_font_manager()
self.assertIsInstance(font_manager, FontManager)

def test_findFont(self):
# Warning because there are no families defined.
with self.assertWarns(UserWarning):
font = findfont(
FontProperties(
family=[],
weight=500,
)
)
# The returned value is a file path
# This assumes there exists fonts on the system that can be loaded
# by the font manager while the test is run.
self.assertTrue(os.path.exists(font))


@contextlib.contextmanager
def change_ets_app_dir(dirpath):
Expand Down