Skip to content

Rename test module so it gets discovered by unittest#528

Merged
rahulporuri merged 1 commit into
masterfrom
cln/rename-test-file
Jan 5, 2021
Merged

Rename test module so it gets discovered by unittest#528
rahulporuri merged 1 commit into
masterfrom
cln/rename-test-file

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

This PR renames a test module so that it gets discovered by unittest. This change was missed when we switched from using nose to unittest as the test runner - #475

On master, there are 295 tests run on a windows machine with 32 tests skipped. On this branch, there are 312 tests run with 32 tests skipped. Note that the tests were run in an environment with pyqt5 i.e.

python ci\edmtool.py install --toolkit pyqt5
python ci\edmtool.py test --toolkit pyqt5

This was missed when we switched from using nose to unittest as the test
runner

	renamed:    kiva/tests/agg/image_test_case.py -> kiva/tests/agg/test_image.py
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 31, 2020

Codecov Report

Merging #528 (1353bac) into master (573469c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #528   +/-   ##
=======================================
  Coverage   35.16%   35.16%           
=======================================
  Files         210      210           
  Lines       17840    17840           
  Branches     2454     2454           
=======================================
  Hits         6274     6274           
  Misses      11161    11161           
  Partials      405      405           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573469c...1353bac. Read the comment docs.

Copy link
Copy Markdown
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@rahulporuri rahulporuri merged commit 682d3fc into master Jan 5, 2021
@rahulporuri rahulporuri deleted the cln/rename-test-file branch January 5, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants