Move to a single setup.py file#534
Closed
jwiggins wants to merge 1 commit into
Closed
Conversation
Member
Author
|
GitHub is being a jerk. Closing and reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #440
This brings all the extension building into the single top-level setup.py script. I'm kinda curious if this will pass CI, since I've only tested it on macOS.
Some changes:
ALWAYS_32BIT_WORKAROUNDfor 64-bit machines with g++ < 4.0macportextension, used for Wx 2.6 support, is not longer built.--compiler=STRoption forsetup.py develophas been removed.cleanandbuild_pycommands are gone, as is the explicit use of numpy distutils.NOTE: The
sdistlooks like it might be broken.NOTE: This conflicts pretty massively with #392