Move to a single setup.py file#535
Conversation
|
Offline discussion: We may want to consider this as a proof-of-concept given the nontrivial conflicts with #392. |
b606f82 to
d43a1d2
Compare
|
Finally. The installation is failing because of the (You should see Just need to figure out how to get SWIG-generated (The exact same problem as described here: https://stackoverflow.com/questions/64638474/pythons-setuptools-doesnt-include-auto-generated-swig-python-files) |
|
Found an answer: https://stackoverflow.com/a/21236111 |
0cc303e to
1e9c515
Compare
ac1f664 to
fef6d32
Compare
fef6d32 to
d4bc4ec
Compare
d4bc4ec to
cce8e3b
Compare
|
This PR has now integrated the changes from #392 and is ready for review! |
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I tested this locally (windows, python 3.6 env) - with and without wheel in the environment - and the instllation went without a hitch.
I could mostly follow the changes between the deletions and the additions - but I trust the CI.
Thanks again @jwiggins for this crucial work.
|
Out of an abundance of caution, I diffed the SDISTs between this branch and master and found a couple changes that needed to be made. |
|
Thanks for the review! |
Thank you. Not sure why that didn't occur to me :/ |
Not enough painful memories to draw from? |
Closes #440
This brings all the extension building into the single top-level setup.py script.
Some changes:
ALWAYS_32BIT_WORKAROUNDfor 64-bit machines with g++ < 4.0macportextension, used for Wx 2.6 support, is not longer built.--compiler=STRoption forsetup.py develophas been removed.cleanandbuild_pycommands are gone, as is the explicit use of numpy distutils.NOTE: Thesdistlooks like it might be broken.NOTE: This conflicts pretty massively with #392