Allow scaling in agg's draw_marker_at_points#594
Merged
Conversation
rahulporuri
reviewed
Feb 19, 2021
Comment on lines
+1192
to
+1196
| mx = pts[i]; | ||
| my = pts[i+1]; | ||
| ctm.transform(&mx, &my); | ||
| // XXX: Assuming scale is uniform in both directions | ||
| m.marker(int(mx), int(my), size * sx, type); |
Contributor
There was a problem hiding this comment.
I am not entirely sure how this change works.
Previously, we were storing the translation in x and y as tx and ty - and then adding markers at pts[i]+tx and pts[i+1]+ty.
Now, we're storing the scale information in sx and sy, transforming the context manager by pts[i] and pts[i+1] and then also add markers at pts[i] and pts[i+1]?
Member
Author
There was a problem hiding this comment.
ctm is the "current transformation matrix". We're applying it to (mx, my), which the position of the current marker. Then we're calling the marker method on the marker renderer to render a marker at the position (mx, my) and scaling its size by sx.
rahulporuri
approved these changes
Feb 19, 2021
Member
Author
|
Thanks for the review |
jwiggins
added a commit
that referenced
this pull request
Feb 19, 2021
jwiggins
added a commit
that referenced
this pull request
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be need to keep Chaco's colormapped scatterplot renderer working if #591 is merged.