Add a celiagg kiva backend for Wx#608
Merged
Merged
Conversation
725fea7 to
bc96a6b
Compare
Contributor
|
I see the following tracebacks from the command line when i run the kiva explorer demo in the wx backend + celiagg backend. |
rahulporuri
approved these changes
Feb 24, 2021
Contributor
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I tested the changes by setting the ETS_TOOLKIT environment variable to wx.celiagg and running the kiva_explorer. Apart from a few unrelated traitsui errors, this seems to do the job.
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking towards #414, we should have a celiagg backend for Wx. This PR supplies one.