Skip to content

Add a celiagg kiva backend for Wx#608

Merged
jwiggins merged 1 commit into
masterfrom
feature/wx-celiagg
Feb 24, 2021
Merged

Add a celiagg kiva backend for Wx#608
jwiggins merged 1 commit into
masterfrom
feature/wx-celiagg

Conversation

@jwiggins
Copy link
Copy Markdown
Member

Looking towards #414, we should have a celiagg backend for Wx. This PR supplies one.

@rahulporuri
Copy link
Copy Markdown
Contributor

I see the following tracebacks from the command line when i run the kiva explorer demo in the wx backend + celiagg backend.

> set ETS_TOOLKIT="wx.celiagg"
> python kiva_explorer.py
Traceback (most recent call last):
  File "C:\Users\rporuri\.edm\envs\enable-test-3.6-wx\lib\site-packages\traitsui\wx\code_editor.py", line 375, in _style_needed
    self.control.StartStyling(position, stc.STC_INDIC2_MASK)
TypeError: StyledTextCtrl.StartStyling(): too many arguments
Traceback (most recent call last):
  File "C:\Users\rporuri\.edm\envs\enable-test-3.6-wx\lib\site-packages\traitsui\wx\code_editor.py", line 375, in _style_needed
    self.control.StartStyling(position, stc.STC_INDIC2_MASK)
TypeError: StyledTextCtrl.StartStyling(): too many arguments
Traceback (most recent call last):
  File "C:\Users\rporuri\.edm\envs\enable-test-3.6-wx\lib\site-packages\traitsui\wx\code_editor.py", line 375, in _style_needed
    self.control.StartStyling(position, stc.STC_INDIC2_MASK)
TypeError: StyledTextCtrl.StartStyling(): too many arguments

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested the changes by setting the ETS_TOOLKIT environment variable to wx.celiagg and running the kiva_explorer. Apart from a few unrelated traitsui errors, this seems to do the job.

@jwiggins
Copy link
Copy Markdown
Member Author

Thanks for the review!

@jwiggins jwiggins merged commit c78ee6f into master Feb 24, 2021
@jwiggins jwiggins deleted the feature/wx-celiagg branch February 24, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants