Fix font selection in the QPainter backend#641
Merged
Conversation
jwiggins
force-pushed
the
fix/qpainter-select-font
branch
from
a191049 to
17cf0fd
Compare
jwiggins
commented
Feb 28, 2021
| # ---------------------------------------------------------------- | ||
|
|
||
| def select_font(self, name, size, textEncoding): | ||
| def select_font(self, name, size, style="regular", encoding=None): |
Member
Author
There was a problem hiding this comment.
Note that this is the signature from AbstractGraphicsContext
Member
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a drive-by fix. While testing #605 and comparing to the
kiva.qpainterbackend, I realized that it was ignoring bold and italic preferences for fonts. This corrects that, such that thestyleattribute of aFontis now honored.