Update the Kiva GraphicsContext documentation#644
Merged
Conversation
corranwebster
approved these changes
Mar 1, 2021
Member
Author
|
@corranwebster Thanks for the review. I actually made a major change while you were in the process of reviewing. This documentation now specifically references the |
jwiggins
commented
Mar 1, 2021
rahulporuri
approved these changes
Mar 1, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the docs refactor!
| of the following: "gray8", "rgb555", "rgb565", "rgb24", "bgr24", "rgba32", | ||
| "argb32", "abgr32", "bgra32". | ||
|
|
||
| ``interpolation`` determines the interpolation used by scaled image drawing |
Contributor
There was a problem hiding this comment.
not sure why we removed this from the docstring. looks like this isnt available consistently across the various supported backends.
Member
Author
|
Thanks for the feedback. Should we consider #618 closed now? @corranwebster? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most, but not all of #618. This nearly covers all the methods of GraphicsContext.