Skip to content

Add a page for comparing backend outputs#661

Merged
jwiggins merged 1 commit into
masterfrom
feature/backend-comparison
Mar 2, 2021
Merged

Add a page for comparing backend outputs#661
jwiggins merged 1 commit into
masterfrom
feature/backend-comparison

Conversation

@jwiggins
Copy link
Copy Markdown
Member

@jwiggins jwiggins commented Mar 2, 2021

Mentioned on #651, but there's no issue.

@jwiggins jwiggins requested a review from rahulporuri March 2, 2021 10:48
Comment thread enable/gcbench/bench.py
"min": times.min() * 1000,
"mean": times.mean() * 1000,
"min": times.min() * 1000,
"max": times.max() * 1000,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the order of this dictionary when turning it into an HTML table

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now that we only support python >= 3.6.

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't thoroughly examine the code but I did check the output - which looks awesome. Thanks for putting this together! LGTM.

Comment thread enable/gcbench/bench.py
"min": times.min() * 1000,
"mean": times.mean() * 1000,
"min": times.min() * 1000,
"max": times.max() * 1000,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now that we only support python >= 3.6.

@jwiggins
Copy link
Copy Markdown
Member Author

jwiggins commented Mar 2, 2021

Yeah. I really like seeing all the outputs next to each other. This is really helpful for #648

@jwiggins jwiggins merged commit 5c25b64 into master Mar 2, 2021
@jwiggins jwiggins deleted the feature/backend-comparison branch March 2, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants