Skip to content

Supply DPI when saving images#678

Merged
jwiggins merged 3 commits into
masterfrom
feature/save-with-dpi
Mar 5, 2021
Merged

Supply DPI when saving images#678
jwiggins merged 3 commits into
masterfrom
feature/save-with-dpi

Conversation

@jwiggins
Copy link
Copy Markdown
Member

@jwiggins jwiggins commented Mar 4, 2021

Fixes #593

Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Effectively just one comment about magic numbers

Comment thread kiva/agg/src/graphics_context.i Outdated
Comment thread kiva/agg/src/graphics_context.i
Comment thread kiva/celiagg.py Outdated
Comment thread kiva/quartz/ABCGI.pyx
Comment thread kiva/tests/test_agg_drawing.py
@jwiggins
Copy link
Copy Markdown
Member Author

jwiggins commented Mar 5, 2021

Thanks for the feedback

@jwiggins jwiggins merged commit 59118b3 into master Mar 5, 2021
@jwiggins jwiggins deleted the feature/save-with-dpi branch March 5, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

save() methods of GraphicsContext implementations should record DPI

2 participants