Document image drawing in Kiva#680
Merged
Merged
Conversation
aaronayres35
approved these changes
Mar 4, 2021
Contributor
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
Unrelated to this PR, but while reviewing I went through the kiva examples looking for an image one. running the image_explorer.py example I saw the following error:
$ python image_explorer.py
2021-03-04 12:20:39.724 Python[18846:396139] ApplePersistenceIgnoreState: Existing state will not be touched. New state will be written to (null)
Traceback (most recent call last):
File "/Users/aayres/Desktop/enable/enable/qt4/base_window.py", line 243, in paintEvent
self.handler.paintEvent(event)
File "/Users/aayres/Desktop/enable/enable/qt4/base_window.py", line 78, in paintEvent
self._enable_window._paint(event)
File "/Users/aayres/Desktop/enable/enable/abstract_window.py", line 506, in _paint
self.component.draw(gc, view_bounds=(0, 0, size[0], size[1]))
File "/Users/aayres/Desktop/enable/enable/component.py", line 432, in draw
self._draw(gc, view_bounds, mode)
File "/Users/aayres/Desktop/enable/enable/component.py", line 813, in _draw
self._dispatch_draw(layer, gc, view_bounds, mode)
File "/Users/aayres/Desktop/enable/enable/component.py", line 831, in _dispatch_draw
handler(gc, view_bounds, mode)
File "image_explorer.py", line 40, in _draw_mainlayer
gc.draw_image(self.image, (0, 0, gc.width(), gc.height()))
File "/Users/aayres/Desktop/enable/kiva/agg/agg.py", line 1379, in draw_image
return _agg.GraphicsContextArray_draw_image(self,img,rect,force_copy)
TypeError: in method 'GraphicsContextArray_draw_image', argument 2 of type 'kiva::graphics_context_base *'
Abort trap: 6
This probably warrants an issue?
Member
Author
|
Thanks for the feedback. |
Member
Author
|
#681 added to track the image_explorer.py issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #616