Normalize some signatures of Kiva methods#691
Conversation
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
are there any documentation updates that need to happen? It looks like we use automethod now so I don't think there should.
Looking at that though I noticed we still have some old doc files in docs/kiva/agg. We can probably delete these? eg https://github.com/enthought/enable/blob/master/docs/kiva/agg/interface.txt
| with self: | ||
| # Kiva uses the fill color for text | ||
| brush = self.gc.brush() | ||
| self.gc.setPen(brush.color()) |
There was a problem hiding this comment.
verified this with the benchmark 👍
| def set_character_spacing(self): | ||
| """ | ||
| """ | ||
| pass | ||
|
|
||
| def get_character_spacing(self): | ||
| """ Get the current font """ | ||
| raise NotImplementedError | ||
|
|
||
| def set_text_drawing_mode(self): | ||
| """ | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Just to clarify, why did these get removed?
There was a problem hiding this comment.
They're covered by GraphicsContextBase
|
Documentation is covered by |
3 participants
This is part of an ongoing effort to address #648
AbstractGraphicsContextto reflect how a majority of backends have something implemented (gradients,show_text,draw_path_at_points,set_line_dash).show_textwith thepoint=kwarg was refactored for many of the lesser-used backends.select_fontnow has the correct signature on celiagg, PDF, and Quartz backends.