Remove old/broken code#692
Merged
Merged
Conversation
rahulporuri
approved these changes
Mar 10, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. Let's give folks until the end of the day to complain if they don't want this PR to get merged.
Contributor
|
I've searched the enthought org in github for all of the removed modules - and i don't see any *working uses (*working because there are older imports from the enthought namespace). I get a lot of false positives when I try to search all code in github. I think it's safe to merge this PR and release the changes in the upcoming release - I dont expect any internal projects to have issues - and I don't expect external users to have issues either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #685
This PR removes modules which are not used anywhere / have been broken for some time as described in the issue. It also removes a few sections of commented out code.
None of these removals should cause any other code to break that wasn't already broken.