Skip to content

Reorder the preferred fonts list#698

Merged
jwiggins merged 1 commit into
masterfrom
fix/default-sans-all-styles
Mar 10, 2021
Merged

Reorder the preferred fonts list#698
jwiggins merged 1 commit into
masterfrom
fix/default-sans-all-styles

Conversation

@jwiggins
Copy link
Copy Markdown
Member

Closes #406

Since "Lucida Grande" doesn't come with all four styles on macOS, we're demoting to lower in the list of sans-serif family names. "Arial" and "Verdan" both have all the styles on macOS and Windows.

(Also adding "Helvetica Neue" to the mix just for funsies)

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwiggins
Copy link
Copy Markdown
Member Author

The new default font results (excuse the magic numers for style):

In [1]: from kiva.fonttools import Font                                         

In [2]: Font(style=0).findfont()                                                
Out[2]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=0)

In [3]: Font(style=1).findfont()                                                
Out[3]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=1)

In [4]: Font(style=2).findfont()                                                
Out[4]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=2)

In [5]: Font(style=3).findfont()                                                
Out[5]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=3)

In [6]: Font("modern", style=0).findfont()                                      
Out[6]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=0)

In [7]: Font("modern", style=1).findfont()                                      
Out[7]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=1)

In [8]: Font("modern", style=2).findfont()                                      
Out[8]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=2)

In [9]: Font("modern", style=3).findfont()                                     
Out[9]: FontSpec(/System/Library/Fonts/HelveticaNeue.ttc, face_index=3)

@jwiggins
Copy link
Copy Markdown
Member Author

Thanks for the review

@jwiggins jwiggins merged commit 07fa279 into master Mar 10, 2021
@jwiggins jwiggins deleted the fix/default-sans-all-styles branch March 10, 2021 14:09
@rahulporuri
Copy link
Copy Markdown
Contributor

rahulporuri commented Mar 10, 2021

and here's what i see on windows -

>>> from kiva.fonttools import Font

>>> Font(style=0).findfont().filename
'c:\\windows\\fonts\\arial.ttf'

>>> Font(style=1).findfont().filename
'c:\\windows\\fonts\\arialbd.ttf'

>>> Font(style=2).findfont().filename
'c:\\windows\\fonts\\ariali.ttf'
>>> Font(style=2).findfont().face_index
0

>>> Font(style=3).findfont().filename
'c:\\windows\\fonts\\arialbi.ttf'

>>> Font("modern", style=0).findfont().filename
'c:\\windows\\fonts\\arial.ttf'

>>> Font("modern", style=1).findfont().filename
'c:\\windows\\fonts\\arialbd.ttf'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default font on macOS doesn't have italic

2 participants