Move some constants not yet moved#702
Merged
Merged
Conversation
aaronayres35
approved these changes
Mar 10, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
It is effectively inconsequential, but the other constants were left in font_manager.py when they were moved over. Was there a specific reason for removing these in this PR and not the others in the previous PR? Not a suggested change or anything, just curious to make sure I'm not missing something
Member
Author
|
The reason is that I have a bunch of parallel changes in flight (all sourced from a branch with a huge diff). The other constants were being moved in #701. I wanted to reduce the size of the big code deletion PR that's coming up. |
jwiggins
force-pushed
the
refactor/move-constants
branch
from
2d66245 to
035084a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constants weren't moved in #701, so doing it here will reduce the noise of the upcoming code purge PR.