Document Enable trait types#721
Merged
Merged
Conversation
aaronayres35
approved these changes
Mar 15, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
Most of the links appear to be dead. Trait definitions are strange though so I think they may not even have api docs correctly generated.
see https://docs.enthought.com/enable/api/enable.api.html#enable-trait-types
seems like the markers do so they could be linked, but that is probably unnecessary
| @@ -0,0 +1,45 @@ | |||
| Enable Custom Traits | |||
| ==================== | |||
| Enable defines several `trait types <https://docs.enthought.com/traits>`_ which | |||
Contributor
There was a problem hiding this comment.
Maybe link to the custom traits section of the traits docs?
https://docs.enthought.com/traits/traits_user_manual/custom.html
I actually am unsure which would make more sense, so feel free to leave if you prefer the home page
Member
Author
There was a problem hiding this comment.
I'll leave it like this
Member
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631