Remove default_size and __default_weight from FontManager#723
Merged
Conversation
rahulporuri
approved these changes
Mar 16, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM.
IIUC, the user-facing behavior that changes in this PR is the fact that the user can no longer use relative sizes to set font size. Is that correct? But IIUC, the user was never actually able to use relative sizes for fonts because the code has been broken for a while now.
Member
Author
|
Yes, that's correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #709
One more disruptive change for
kiva.fonttools. This removes thedefault_sizeattribute fromFontManager, plus all related code. Additionally the unused__default_weightattribute is also removed andFontPropertieshas been renamed toFontQueryto better reflect how it is actually used (internally, I'll add).