Add support for text styles on Win32+Celiagg#726
Merged
Conversation
Member
Author
|
This will have to wait for the celiagg release, or else I'll have to add a check for the presence of |
rahulporuri
approved these changes
Mar 19, 2021
Contributor
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I tested this locally on my windows machine and it worked like a charm - not with celiagg 2.0 on edm but 2.1.0 on pypi. Tested using the kiva_explorer with the default "Times New Roman" font.
870d0bf to
9a1124f
Compare
Member
Author
|
Thanks for the testing/review @rahulporuri! |
jwiggins
added a commit
that referenced
this pull request
Mar 22, 2021
jwiggins
added a commit
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #643
Celiagg 2.1.0 introduces a new font object for win32 which allows specification of bold/italic styles.