Basic analysis of the script content of strings#764
Merged
Conversation
jwiggins
commented
Mar 29, 2021
Comment on lines
+113
to
+114
| 94: "Tai_Le", | ||
| 95: "New_Tai_Lue", |
Member
Author
There was a problem hiding this comment.
These were changed to match the names in kiva.fonttools.text._data.
rahulporuri
approved these changes
Mar 30, 2021
|
|
||
| def _lookup_codepoint(self, cp): | ||
| comps = self.ranges - ord(cp) | ||
| index = ((comps[:, 0] <= 0) == (comps[:, 1] >= 0)).argmax() |
Contributor
There was a problem hiding this comment.
This looks like the most important detail in the PR - how we're selecting the entry given a code point - and it'd be useful if you could elaborate on how we're doing it.
Contributor
|
still LGTM |
Member
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another part of #762
There are two pieces here, and a ton of machine-generated code (don't fear the diff):
kiva.fonttools.text._datamodule.UnicodeAnalyzerwhich uses the data fromScripts.txtand returns the languages and slices for a given input string.UnicodeAnalyzeris pretty basic right now. I'd like to keep it that way in this PR. For instance, Emoji ligatures are not great: