remove __getstate__ methods and use transient metadata#804
Merged
Conversation
aaronayres35
commented
Apr 28, 2021
| self._update_region = [] | ||
|
|
||
| def __getstate__(self): | ||
| attribs = ("component", "bgcolor", "overlay", "_scroll_origin") |
Contributor
Author
There was a problem hiding this comment.
_scroll_origin is set to (0,0) in the __init__ method, but I don't see it used anywhere. A search of the chaco and enable codebases yields 0 results. Perhaps it can just be removed entirely?
Member
There was a problem hiding this comment.
Yeah, it should probably just be removed. I also don't see it being used in some older internal codebases.
aaronayres35
commented
Apr 28, 2021
|
|
||
| # (dx, dy) integer size of the Window. | ||
| _size = Trait(None, Tuple) | ||
| _size = Trait(None, Tuple, transient=True) |
Contributor
Author
There was a problem hiding this comment.
I added transient=True for all traits that were previously explicitly listed in __getstate__ to preserve behavior. Perhaps we should re-evaluate though what actually should/shouldn't be transient
aaronayres35
changed the title
rahulporuri
approved these changes
Jun 2, 2021
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
aaronayres35
added a commit
that referenced
this pull request
Jun 10, 2021
* remove __getstate__ methods and use transient metadata * remove _scroll_origin * Update enable/abstract_window.py Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
aaronayres35
added a commit
that referenced
this pull request
Jun 11, 2021
* remove __getstate__ methods and use transient metadata (#804) * remove __getstate__ methods and use transient metadata * remove _scroll_origin * Update enable/abstract_window.py Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Set transient metadata and pull up __getstate__ method (#841) * set transient metadata on traits who (according to subclasses) should be transient * import Int * actually we do need getstate because stack_index is a class attribute. Pull getstate method down here to the baseclass * remove PICKLE FIXME comment Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #795
This PR simply replaces the use of
__getstate__methods by settingtransientmetadata on relevant traits.HasTraitshandles this with its own__getstate__method appropriately.EDIT: It also removes the unused
_scroll_originattribute onAbstractWindow.