Skip to content

Enable Release Candidate 5.2.0rc2#837

Merged
aaronayres35 merged 2 commits into
maint/5.2from
release-candidate-5.2.0
Jun 1, 2021
Merged

Enable Release Candidate 5.2.0rc2#837
aaronayres35 merged 2 commits into
maint/5.2from
release-candidate-5.2.0

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

The merge commit from this PR will be tagged as the 5.2.0 release candidate (this time for real)

@aaronayres35 aaronayres35 mentioned this pull request Jun 1, 2021
38 tasks
@aaronayres35 aaronayres35 requested a review from rahulporuri June 1, 2021 17:28
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. We already have a commit in the maint/5.2 branch which is an rc1 release. This needs to be an rc2 release because we shouldn't have two commits which mark the same version.

@aaronayres35
Copy link
Copy Markdown
Contributor Author

This doesn't look right. We already have a commit in the maint/5.2 branch which is an rc1 release. This needs to be an rc2 release because we shouldn't have two commits which mark the same version.

Ah okay I see, I wasn't thinking at a commit level, I was thinking since the tag for the other was removed we could simply tag this instead. I will update this to be "rc2".

@aaronayres35 aaronayres35 changed the title Enable Release Candidate 5.2.0rc1 Enable Release Candidate 5.2.0rc2 Jun 1, 2021
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit ce7e647 into maint/5.2 Jun 1, 2021
@jwiggins jwiggins deleted the release-candidate-5.2.0 branch June 18, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants