Fix bug when no fonts are available#871
Merged
Merged
Conversation
aaronayres35
commented
Jul 14, 2021
rahulporuri
changed the title
Contributor
|
I've removed the WIP label. |
jwiggins
reviewed
Jul 15, 2021
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
I think we should raise a warning here as suggested by @rahulporuri in #870
Member
|
Celiagg includes the free Montserrat font. |
jwiggins
reviewed
Jul 15, 2021
aaronayres35
commented
Jul 15, 2021
Member
|
Due to the new file, you will also need to update:
|
Contributor
Author
|
Thanks @jwiggins! |
aaronayres35
commented
Jul 16, 2021
jwiggins
approved these changes
Jul 16, 2021
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
I would test the packaging, but otherwise LGTM
Contributor
Author
|
I built an sdist and saw the font file was included as expected. I then pip installed the sdist in a fresh env and ran the test added here which passed (ie the font was available). Gonna go ahead and merge now |
Member
|
Thanks for the quick fix here @aaronayres35 |
aaronayres35
added a commit
that referenced
this pull request
Jul 16, 2021
* add a failing regression test * make test pass with a 'fix' of using a TestTTF font already available in the package * use default font from celiagg and update test * actually add the ttf file and license * move license to LICENSES folder rather than directly next to font file * update manifest.in setup.py and font_license.txt
Closed
aaronayres35
added a commit
that referenced
this pull request
Jul 19, 2021
* add a failing regression test * make test pass with a 'fix' of using a TestTTF font already available in the package * use default font from celiagg and update test * actually add the ttf file and license * move license to LICENSES folder rather than directly next to font file * update manifest.in setup.py and font_license.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #870
Currently it only includes a failing regression test. Current plan for a fix is to include a basic freely licensed font with kiva that can be used as a default if we can't find anything else.EDIT: I've added a quick fix of using aTestTTF.ttffont we already had included in the package for testing as the default if we can't find any other fonts. This prevents the failure, but we may want to include a more legitimate default with the package? TBH I don't know very much at all about fonts / ttf so I'm not sure what would make a good default here.