Fix the dpi related cron job failures#875
Merged
Merged
Conversation
Contributor
Author
|
I've manually triggered the cron job on this branch to verify this fix: https://github.com/enthought/enable/actions/runs/1045927150 EDIT: ah and it doesn't fix it! |
aaronayres35
added a commit
that referenced
this pull request
Jul 20, 2021
* add an int() call to fix test suite failures * use round not int
aaronayres35
added a commit
that referenced
this pull request
Jul 20, 2021
* Fix the dpi related cron job failures (#875) * add an int() call to fix test suite failures * use round not int * update changelog withh latest fix * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
aaronayres35
added a commit
that referenced
this pull request
Jul 20, 2021
* Fix the dpi related cron job failures (#875) * add an int() call to fix test suite failures * use round not int * update changelog withh latest fix * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
aaronayres35
added a commit
that referenced
this pull request
Jul 20, 2021
* update changelog in advance of 5.2.1 (#874) * update changelog in advance of 5.2.1 * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Backport cron job fix (#876) * Fix the dpi related cron job failures (#875) * add an int() call to fix test suite failures * use round not int * update changelog withh latest fix * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a recent
pillowrelease which included this change: python-pillow/Pillow#5476That was causing the cron job to fail with:
This PR simply adjusts for this by adding an
int()call when we get the dpi. Note the above pillow PR explains why this started occurring.fixes #866