Skip to content

Fix text locale test issue on Windows #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corranwebster merged 8 commits into from
Mar 10, 2022
Merged

Fix text locale test issue on Windows #901

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
754d3f0
Fix text locale test issue on Windows
corranwebster Mar 7, 2022
8316b74
Skip test on windows with explanation.
corranwebster Mar 9, 2022
767f7c2
Fail rather than skip if setlocale fails.
corranwebster Mar 9, 2022
06d199e
Try ("C", "ASCII") locale instead of ("en", "ASCII")
corranwebster Mar 9, 2022
5d842d4
Try using ("C", "ASCII") instead of ("en", "ASCII")
corranwebster Mar 9, 2022
e25a329
Use 'utf8' rather then 'UTF-8' for locale encoding.
corranwebster Mar 9, 2022
a2bd871
Still issues on windows - skip
corranwebster Mar 9, 2022
96fb5fe
Add back skip at Robert's suggestion.
corranwebster Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions kiva/tests/agg/test_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
# Thanks for using Enthought open source!
from contextlib import contextmanager
import locale
import sys
import unittest

from kiva import agg
Expand All @@ -31,12 +32,18 @@ def locale_context(category, new=None):


class TestText(unittest.TestCase):

@unittest.skipIf(
sys.platform == "win32",
"Skipping on windows due to issues with setlocale. "
"See issue #899 and https://bugs.python.org/issue38324",
)
def test_locale_independence(self):
# Ensure that >ASCII Unicode text is decoded correctly regardless of
# the locale.
text = "\N{GREEK SMALL LETTER MU}"

with locale_context(locale.LC_CTYPE, ("en", "UTF-8")):
with locale_context(locale.LC_CTYPE, ("en", "utf8")):
gc = agg.GraphicsContextArray((200, 200))
f = Font("modern")
with gc:
Expand All @@ -46,7 +53,7 @@ def test_locale_independence(self):
gc.show_text(text)
x0, _ = gc.get_text_position()

with locale_context(locale.LC_CTYPE, ("en", "ASCII")):
with locale_context(locale.LC_CTYPE, ("C", "ASCII")):
gc = agg.GraphicsContextArray((200, 200))
f = Font("modern")
with gc:
Expand Down