Ensure toolkit is initialized before use#921
Merged
Merged
Conversation
In a number of places the code used ETSConfig.toolkit to determine the backend at import time. However it is possible that that value was being checked before ETSConfig.toolkit was properly set. This changes the code to get the appropriate Pyface or TraitsUI toolkit object and gets the name of the toolkit from that. This fixes #913.
Also fix a couple more uses of ETSConfig.toolkit.
jwiggins
reviewed
Apr 3, 2022
jwiggins
reviewed
Apr 3, 2022
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
I think the enable bits are OK, but I think we need to keep in mind that kiva should work in places where no GUI is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a number of places the code used ETSConfig.toolkit to determine the backend at import time. However it is possible that that value was being checked before ETSConfig.toolkit was properly set. This changes the code to get the appropriate Pyface or TraitsUI toolkit object and gets the name of the toolkit from that.
This fixes #913.
This doesn't attempt to fix #904.