Remove usage of Trait()#925
Merged
Merged
Conversation
mdickinson
reviewed
Apr 6, 2022
Member
mdickinson
left a comment
mdickinson
left a comment
There was a problem hiding this comment.
Code changes look good to me, modulo one nitpick.
There's a good amount of logic in the ScrollBarRange and ScrollPosition trait types - it would be worth adding some tests for those.
| from enable.primitives.api import Box | ||
| from enable.enable_traits import Pointer | ||
| from traits.api import Event, Float, Trait, Tuple | ||
| from traits.api import Event, Float, Union, Tuple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This largely removes the usage of
Trait()in the codebase. The places where it is not changed are inenable.color(which is resolved by #924) and in theKivaFontTraitwhich is complex enough to deserve its own PR.The PR was done in stages, each commit doing a different type of trait replacement (eg. Trait -> Union, Trait -> Map, etc.) so it may be easier to review one commit at a time.
Fixes #417.