FIX: Use correct path to the default font#931
Merged
Conversation
jwiggins
reviewed
Apr 13, 2022
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
Good eye. Can you add a unit test which actually exercises this code path?
Contributor
|
I am adding tests for this - most of the machinery is already in the test suite so it's fairly straighforward. |
corranwebster
approved these changes
Apr 19, 2022
Contributor
corranwebster
left a comment
corranwebster
left a comment
There was a problem hiding this comment.
I approve of the fix, but since I wrote the tests it might make sense to have another set of eyes on my contribution.
jwiggins
approved these changes
Apr 19, 2022
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #930. Fixes a typo in the default font filename