Skip to content

Backports for 5.3 maintenance branch#965

Merged
corranwebster merged 14 commits into
maint/5.3from
fix/backport-maint-5-3
Aug 12, 2022
Merged

Backports for 5.3 maintenance branch#965
corranwebster merged 14 commits into
maint/5.3from
fix/backport-maint-5-3

Conversation

@corranwebster
Copy link
Copy Markdown
Contributor

Does what it says.

Poruri Sai Rahul and others added 14 commits July 25, 2022 11:19
* DOC: Use the sphinx-copybutton extension in documentation

	modified:   ci/edmtool.py
	modified:   docs/source/conf.py
	modified:   enable/__init__.py

* Update ci/edmtool.py
Addresses these warnigns/exceptions:
- TypeError: BitmapFromImage() got an unexpected keyword argument 'depth'
- AttributeError: 'PaintDC' object has no attribute 'BeginDrawing'
- wxPyDeprecationWarning: Call to deprecated item EmptyImage. Use :class:`Image` instead.
    image = wx.EmptyImage(*sz)
- wxPyDeprecationWarning: Call to deprecated item BitmapFromImage. Use :class:`wx.Bitmap` instead
    bmp = wx.BitmapFromImage(image, depth=-1)

See https://forums.wxwidgets.org/viewtopic.php?t=39930 why the Begin/EndDrawing calls can simply be removed.

Related issues: #798 and #531
* Experiment with installing SWIG from PyPI

* Update the EDM-based workflow

* Remove restriction on SWIG version

* Add Cython back as a development dependency; remove verify_swig_install
* Add regression test for Enable #964.

* Properly decode strings in Kiva Quartz font code.

* Properly guard against running Quartz tests on non-Mac systems.

* Ensure Wx Quartz test terminates.

* Make test success externally visible.

* Fix tests, use UTF-8.
* Add a github workflow that publishes to sdists to PyPI on release.

* Use build to build the sdist.
* Use font family in quartz when no font name given.

* Render quartz text with fill color rather than stroke color.
* Add a test for #971

This should fail CI.

* Fix bug and clean-up style.
* Correct first point and orientation of Kiva QPainter arcs.

This fixes #962 but not #960.

* Update kiva/qpainter.py
* Fall back to kiva.fonttools if Qt can't come up with a font name.

* Add a comment about setFamilies()
Some changes to tests to make sure eveything is tested correctly.
* Fix the rendering of polygons in basecore2d-based backends

This:

- consistently uses Nx2 numpy arrays to store path points
- doesn't create a new subpath after a LINES function

A driveby fix gives a default implementation for show_text_at_point().

* Clean-up comments.

* Fix some unused imports.

* Some of the unused imports are in fact used.

* Improve the situation of line_state_equal a bit.

* Ensure all subpath arguments are numpy arrays.
* Ensure all backends implement arc_to and quad_curve_to.

* Fix 'infomration' typo in comments in multiple files.

* Fixes suggested from PR review.
@corranwebster corranwebster marked this pull request as ready for review August 12, 2022 10:27
Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit 719af59 into maint/5.3 Aug 12, 2022
@corranwebster corranwebster deleted the fix/backport-maint-5-3 branch August 12, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants